fix: submarine builds #1428
Merged
fix: submarine builds #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lleyton
requested changes
Jul 5, 2024
|
rawhide packages are broken again |
|
upstream packages are broken, merge is stil possible |
|
Tested on a local build (f40, terra mock chroot), seems to build |
nothingneko
previously approved these changes
Jul 9, 2024
korewaChino
changed the title
|
I have attempted to build 590fd9a, works |
Co-authored-by: lea <[email protected]> Signed-off-by: Cappy Ishihara <[email protected]>
korewaChino
force-pushed
the
fix/strip-submarine
branch
from
590fd9a to
81f6a1e
Compare
|
rebased to 40 to work around upstream |
lleyton
approved these changes
Jul 9, 2024
raboneko
pushed a commit
that referenced
this pull request
Jul 9, 2024
* fix: Do not strip binaries in submarine * Update anda/system/submarine/submarine.spec Co-authored-by: lea <[email protected]> Signed-off-by: Cappy Ishihara <[email protected]> --------- Signed-off-by: Cappy Ishihara <[email protected]> Co-authored-by: lea <[email protected]> (cherry picked from commit 3c49f8c)
raboneko
pushed a commit
that referenced
this pull request
Jul 9, 2024
* fix: Do not strip binaries in submarine * Update anda/system/submarine/submarine.spec Co-authored-by: lea <[email protected]> Signed-off-by: Cappy Ishihara <[email protected]> --------- Signed-off-by: Cappy Ishihara <[email protected]> Co-authored-by: lea <[email protected]> (cherry picked from commit 3c49f8c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Merged
madonuko
pushed a commit
that referenced
this pull request
Jul 9, 2024
* fix: Do not strip binaries in submarine * Update anda/system/submarine/submarine.spec Co-authored-by: lea <[email protected]> Signed-off-by: Cappy Ishihara <[email protected]> --------- Signed-off-by: Cappy Ishihara <[email protected]> Co-authored-by: lea <[email protected]> (cherry picked from commit 3c49f8c) Co-authored-by: Cappy Ishihara <[email protected]>
madonuko
pushed a commit
that referenced
this pull request
Jul 9, 2024
* fix: Do not strip binaries in submarine * Update anda/system/submarine/submarine.spec Co-authored-by: lea <[email protected]> Signed-off-by: Cappy Ishihara <[email protected]> --------- Signed-off-by: Cappy Ishihara <[email protected]> Co-authored-by: lea <[email protected]> (cherry picked from commit 3c49f8c) Co-authored-by: Cappy Ishihara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fixes submarine builds to become bootable, also symlinks the kpart image as
submarine.kpartfor easy scripting access